2014-05-17  iulius

	* Typos

	* Bump version number in FAQ for new INN 2.5.4 release

	* Mention the expected rights for ncmring.gpg in perl-nocem man
	  page

	* Update config.guess and config.sub to upstream versions from
	  2014-05-17

2014-05-14  iulius

	* Document already existing res blocks functionality in
	  readers.conf
	  
	  * Document res blocks, their log: and program: keywords, and the
	  include directive in readers.conf man page.
	  
	  * Recognize res blocks and their keywords in inncheck.
	  
	  * Do not consider as errors in daily reports the lines logged in
	  news.notice by the log: keyword in readers.conf.
	  
	  * Also teach other known lines to innreport (especially the use
	  of "ctlinnd xexec" and normal rejection of nnrpd connections
	  during news.daily operations).
	  
	  * Typo in readers.conf man page (access instead of auth).

	* Prevent innwatch from throttling innd when no overview directory
	  exists
	  
	  Thanks to John F. Morse for the report.

	* Mention in news.daily documentation that lowmark requires
	  expireover
	  
	  Thanks to John F. Morse for the report.

2014-04-13  iulius

	* Update control.ctl to upstream version from 2014-04-06

2014-03-16  iulius

	* Fix typo (two "d" in "address")
	  
	  Also remove the top1000.org domain that no longer exists.

2014-03-15  iulius

	* Fix AC_LANG_PROGRAM warnings from Autoconf 2.68
	  
	  Autoconf 2.68 complains with several: AC_LANG_CONFTEST: no
	  AC_LANG_SOURCE call detected in body
	  
	  Libtool 2.4 (used by INN 2.6) fixed the issue but as INN 2.5
	  still uses Libtool 2.2.6b, just backport commit
	  2680f79c22e6bb1f8b9c7b5428da728b7e028b0c from git Libtool.
	  
	  * m4/libtool.m4 (_LT_SYS_MODULE_PATH_AIX): Fix underquoted
	  AC_LANG_PROGRAM call. * m4/libtool.m4 (_LT_LINKER_SHLIBS) [irix,
	  GCC]: Use the right source for the given language.

	* Handle several UIDs on PGP keys when verifying control messages
	  
	  Fixed a long-standing limitation on how controlchan and pgpverify
	  were checking the signer of control messages. They now properly
	  handle the case of several UIDs being defined on a single PGP
	  key, as well as the presence of spaces into UIDs. In previous
	  versions of INN, a few valid control messages got ignored because
	  of that limitation (fido.ger.* and grisbi.* were for instance
	  impacted).

2014-03-13  iulius

	* Update copyright years

	* Update control.ctl to upstream version from 2014-03-13

	* Update install-sh to upstream version from 2014-03-13

	* Update config.guess and config.sub to upstream versions from
	  2014-03-13

2014-02-17  iulius

	* improve documentation about using storeonxref with tradspool
	  
	  Mention in the inn.conf man page that storeonxref needs being set
	  to true in case the tradspool article storage method is used.
	  
	  Though a few parts of tradspool handle both values for
	  storeonxref, the implementation when storeonxref is false is not
	  complete. For instance, CrackXref() is still called on the
	  Newsgroups: header once, which obviously fails.

	* do not install motd files by default, but only samples
	  
	  On a fresh INN install, motd.innd and motd.nnrpd are no longer
	  installed by default. Instead, samples for these files are
	  provided in >pathetc>, named differently so that their default
	  contents are not displayed to news clients before they get
	  customised.

	* readers.conf: make mandatory the program: key in res blocks
	  
	  Fixed a segfault occurring in nnrpd when a res block was used in
	  readers.conf without the program: key.
	  
	  This key is now explicitly made mandatory.

	* nnrpd: fixed an overlapping copy
	  
	  Fixed an issue where users were denied posting because of an
	  overlapping buffer copy in a check nnrpd was doing.
	  
	  The error seen was "address not in Internet syntax" while using a
	  From: address of the form <a@test1.de>. Debugging revealed that
	  nnrpd copies a buffer into itself to look at the part behind the
	  "@", and for very specific inputs on an old version of nnrpd that
	  still uses strcpy, the result did not contain the dot separating
	  the top-level domain any more.
	  
	  Thanks to Florian Schlichting for the patch.

2014-02-08  iulius

	* add a valid shell when su'ing to the news user
	  
	  Pass "-s /bin/sh" to "su news" to cope with the change of the
	  news user's shell in base-passwd 3.5.30.
	  
	  Thanks to Colin Watson for the patch.

2013-12-27  iulius

	* Mention that --with-sasl requires Cyrus SASL (and not SASL).

2013-12-19  iulius

	* fix typo

	* rewording so as to make the documentation of noresendid clearer

	* mention innduct as a possible replacement for innfeed, innxmit
	  and nntpsend

2013-12-14  iulius

	* ckpasswd: check for both gdbm/ndbm.h and gdbm-ndbm.h headers
	  
	  libgdbm-dev in Debian provides /usr/include/gdbm-ndbm.h whereas
	  gdbm-devel in Red Hat provides /usr/include/gdbm/ndbm.h; INN then
	  has to make sure to search for the right header file when DBM
	  support is found. Define HAVE_GDBM_SLASH_NDBM_H and
	  HAVE_GDBM_HYPHEN_NDBM_H instead of HAVE_GDBM_NDBM_H to properly
	  disambiguate the two headers that are mapped to the same
	  preprocessor name by Autoconf.
	  
	  Thanks to Jesse Rehmer for the bug report.

2013-12-12  iulius

	* innd: fix a segfault when running news.daily
	  
	  On systems where time_t is a 64-bit integer, innd segfaults on
	  "ctlinnd name" commands (for instance when news.daily uses these
	  commands on connected peers).
	  
	  Thanks to S.P. Zeidler for the patch.

2013-12-09  iulius

	* innreport: update the pattern for "strange strings"
	  
	  The "Including strange strings" innreport section is now back in
	  daily Usenet reports. Fix regression introduced with commit
	  [8389].

2013-12-06  eagle

	* Update the URL for BerkeleyDB
	  
	  Oracle has gratuitously reorganized their web pages yet again.

2013-11-26  iulius

	* update links to ISC and Trac
	  
	  * Russ' web site now lists the contributed links that were on the
	  old ISC web site (the new ISC web site is only a download page of
	  the last release). * Accessing Trac now requires a TLS
	  connection.

2013-11-17  iulius

	* fix the path to simpleftp in innshellvars and INN::Config
	  
	  When neither wget nor ncftpget nor ncftp was found at configure
	  time, the path to the simpleftp substitution program shipped with
	  INN was not proprely set in innshellvars, innshellvars.pl, and
	  the INN::Config Perl module. Thanks to Christian Garbs for the
	  bug report.

2013-11-10  iulius

	* getnameinfo.c: sync with rra-c-util
	  
	  Check the return status of snprintf instead of assuming that it
	  will always succeed.

2013-11-06  iulius

	* socket.h: add socket_set_errno
	  
	  Fix a build error because of the introduction of socket_set_errno
	  in commit [9557].
	  
	  Backport commit [9345] to the 2.5 branch.

2013-11-06  eagle

	* Fix another outdated link to BerkeleyDB in the ovdb documentation

	* Fix broken link for obtaining Perl in Perl hook documentation

2013-11-05  iulius

	* inet_ntop.c: sync with rra-c-util
	  
	  - Use socket_set_errno instead of assigning to errno.
	  
	  - Check the return status of snprintf in the inet_ntop
	  replacement function instead of assuming that it will always
	  succeed.

2013-11-03  iulius

	* update changelog for previous commit [9538]

	* asprintf.c: synchronize with rra-c-util
	  
	  In the vasprintf replacement, preserve errno if snprintf fails
	  when formatting the string into the newly-allocated buffer.

2013-10-05  eagle

	* Perl and BerkeleyDB URL updates

2013-09-22  eagle

	* Fix link to the NoCeM registry in the perl-nocem documentation

2013-09-20  iulius

	* fix include directories at configure time for Berkeley DB support
	  
	  Do not add /usr/include and /usr/lib to compiler and linker
	  include directories.

	* fix ovdb documentation about --with-berkeleydb
	  
	  Since commit [7819], likely locations like /usr/include/db44 or
	  /usr/local/BerkeleyDB.4.4 are no longer checked.

2013-08-25  iulius

	* improve the detection of ndbm compatibility layer
	  
	  When INN is configured with Berkeley DB support, ckpasswd tries
	  to use the ndbm compatibility layer provided by Berkeley DB even
	  though Berkeley DB was not built with ndbm support. This patch
	  fixes that, by detecting at configure time that Berkeley DB
	  really has its ndbm compatibility layer.
	  
	  Also add support for gdbm libraries in ckpasswd.

	* do not use yyget_leng() function as it is not defined by old flex
	  versions
	  
	  Better keep using yyleng, still cast to size_t.

2013-08-01  iulius

	* ckpasswd: use Berkeley DB ndbm compatibility layer first
	  
	  On a few systems like Fedora 18 ppc64, the GNU dbm library
	  shipped as ndbm.h is not usable.
	  
	  ckpasswd.c: In function 'password_dbm': ckpasswd.c:165:5:
	  warning: passing argument 1 of 'dbm_open' discards 'const'
	  qualifier from pointer target type [enabled by default] database
	  = dbm_open(file, O_RDONLY, 0600); ^ In file included from
	  ckpasswd.c:30:0: /usr/include/ndbm.h:55:14: note: expected 'char
	  *' but argument is of type 'const char *' extern DBM *dbm_open
	  (char *file, int flags, int mode); ^ ckpasswd.o: In function
	  `password_dbm':
	  /home/iulius/autobuild/inn/authprogs/ckpasswd.c:165: undefined
	  reference to `dbm_open'
	  /home/iulius/autobuild/inn/authprogs/ckpasswd.c:170: undefined
	  reference to `dbm_fetch'
	  /home/iulius/autobuild/inn/authprogs/ckpasswd.c:177: undefined
	  reference to `dbm_close'
	  /home/iulius/autobuild/inn/authprogs/ckpasswd.c:172: undefined
	  reference to `dbm_close' collect2: error: ld returned 1 exit
	  status

2013-07-31  iulius

	* fix three casts to unsigned char when using toupper()
	  
	  GCC complains because of char-subscripts warnings.

	* fix build with flex 2.5.36+
	  
	  Cast yyget_leng() to size_t because it used to be an int in flex
	  versions anterior to 2.5.35 (not included).

2013-07-22  eagle

	* Update the URL for NoCeM

	* Fix another old URL for downloading Perl

	* Update URL to download Perl in the Perl hook documentation

2013-07-08  iulius

	* pullnews: fixed a Perl warning
	  
	  Latest Perl versions catch this use of uninitialized variable.
	  
	  Thanks to Tony Evans for the bug report.

	* pullnews: looks for the config file in the running user's home
	  directory
	  
	  After commits [9304] and [9330], INN 2.5.3 broke the legacy
	  behaviour of pullnews looking for its configuration file in the
	  running user's home directory. Adding INN::Config changed the
	  $HOME environment variable to the news user's home directory (in
	  fact the pathnews parameter set in inn.conf). Besides, pullnews
	  was no longer useable outside INN.
	  
	  Fixed these issues by: - making INN::Config and
	  INN::Utils::Shlock optional. If these Perl modules are not
	  present, pullnews falls back to its legacy handle of locks (that
	  is unfortunately broken in Solaris); - setting the home directory
	  to the one of the running user.
	  
	  Thanks to Tony Evans for the bug report.

2013-07-01  iulius

	* clarify distribution restrictions in the ME entry of the
	  newsfeeds sample file
	  
	  Note in the newsfeeds sample file that restrictions on accepted
	  distributions will have no effect if the article has no
	  distribution at all.
	  
	  Follow up commit [9500].

2013-07-01  eagle

	* Clarify distribution restrictions on articles with none
	  
	  Note in the newsfeeds man page that restrictions on accepted
	  distributions will have no deffect if the article has no
	  distribution at all.

2013-06-25  iulius

	* fix a few resource leaks
	  
	  A few files were remaining open.
	  
	  Thanks to David Binderman for having reported the issue.

	* imapfeed: fix buffer overflow
	  
	  Fixed a buffer overflow when using imapfeed with more than a
	  million commands during the same IMAP session.
	  
	  Thanks to David Binderman for having reported the issue.

	* fix segfault during dereferencing
	  
	  Remove a useless unlink().
	  
	  Thanks to David Binderman for having reported the issue.

2013-06-24  iulius

	* fix a Perl warning in inncheck
	  
	  defined(@array) has been deprecated since Perl 5.16.
	  
	  Thanks to Remco Rijnders for the report.

2013-06-12  iulius

	* document htpasswd and perl commands to generate the auth
	  newsusers database

2013-06-08  iulius

	* mention in INSTALL that CNFS buffers are compatible between LFS
	  and non-LFS vers ions

2013-06-06  iulius

	* properly undef two hashes used in Perl hooks

	* add the attributes hash to nnrpd Perl posting filter
	  
	  The attributes hash was only created for Perl authentication and
	  access functions. It is now accessible to Perl posting filter.
	  
	  Also update the sample filter_nnrpd.pl file.
	  
	  Thanks to Steve Crook for the patch.

2013-06-03  iulius

	* innfeed, scanlogs: reopen log files on sighup
	  
	  The recent patch [9464] to flush exploder and process channels in
	  innd, and to send 'ctlinnd flushlogs' again after log rotation
	  solved the problem of controlchan or ninpaths holding open an
	  already deleted errlog file. However this does not yet solve the
	  original issue with innfeed.log when innfeed is run as a
	  standalone daemon via a funnel-file.
	  
	  This patch implements the changes suggested by Julien Elie in
	  January 2013, to add an openLogFile() call to the sighup handler.
	  The sigusr1 handler is not available, as it is already used to
	  increase / decrease the debugging level along with sigusr2. Also,
	  reopening the log after re-reading the configuration might be a
	  good idea anyway, as the log file location may have been changed.
	  
	  Additionally, call sighup on the innfeed pid in scanlogs, and
	  document the changes briefly in innfeed(8) / innfeed.conf(5).
	  
	  Thanks to Florian Schlichting for the patch.

2013-05-24  iulius

	* rename radius.conf to inn-radius.conf
	  
	  The name of the radius.conf configuration file shipped with INN
	  conflicts with the libradius package. innupgrade will take care
	  of the renaming.
	  
	  Reported by Jochen Schmitt.

2013-05-21  eagle

	* Force the actsync exit code documentation to not be a numbered
	  list
	  
	  POD has changed how it disambiguates numbered lists from
	  description lists and issues a new warning. Force the exit codes
	  to be a description list since they don't start with 1.

2013-05-20  iulius

	* fixed the occurrence of an unexpected "cant select" error
	  generated by innd errno was not preserved; the status hook was
	  stuck between the select and the check of its return status, so
	  we're getting a spurious EPERM from STATUSsummary, probably from
	  some random glibc internal syscall involved in fopen() that isn't
	  actually important.
	  
	  It only happens twice since it can only happen when select is
	  interrupted by a signal (triggering EINTR, which then gets
	  overwritten with EPERM), which is probably due to child processes
	  completing, which is probably only happening during specific
	  events on your server during expire.
	  
	  The solution is to rewrite this code to the order that it should
	  have been written in the first place.
	  
	  Thanks to Paul Tomblin for having caught that long-standing
	  issue.

2013-04-14  iulius

	* compilation with gcc 4.8.0
	  
	  Explicitly give the known size of a pointer used in a snprintf()
	  call in the OfferArticle() function. New
	  -Wsizeof-pointer-memaccess warning introduced in gcc 4.8.0.

2013-03-22  iulius

	* update documentation for the new behaviour of "ctlinnd flushlogs"
	  
	  Also fix a POD error introduced by the previous commit. Thanks to
	  Florian Schlichting for having caught it.

2013-03-18  iulius

	* Rotate innfeed logs
	  
	  Exploder and process channels are now properly reopened when
	  "ctlinnd flushlogs" is used, which is in particular the command
	  invoked by scanlogs to rotate log files. It solves the issue that
	  caused the patch to be reverted by commit [9450].

	* Superfluous character in innfeed.log output

2013-01-16  iulius

	* test suite: remove a useless wrapped test for setenv
	  
	  Remove a test that makes the test suite fail on a few systems.
	  The code it is testing is obvious whereas getting the amount of
	  memory and the data size limits right is extremely difficult in
	  all cases. Besides, this test does not serve much purpose and is
	  not present in rra-c-util 4.7.

	* Typos.
	  
	  Thanks to Florian Schlichting for the report.

2012-12-30  eagle

	* Fix the innfeed configfile parser generation rule
	  
	  Using $? in the rule, now that the extra dependency has been
	  added, caused the wrong arguments to be passed to bison. Pass the
	  correct arguments explicitly.
	  
	  This still seems to run bison twice for reasons that I can't
	  figure out, but that should be harmless.

2012-12-29  eagle

	* Add additional dependency to de-parallelize innfeed yacc rule
	  
	  With a highly parallel make, yacc could be invoked on the innfeed
	  configuration parser twice, once to build the *.c file and once
	  to build the *.h file, leading to one of the mv commands failing.
	  Follow the recommendation in the Automake manual and add an
	  additional dependency from the *.h file to the *.c file, forcing
	  the rule to be run once.
	  
	  Reported by Remco Rijnders.

2012-12-23  eagle

	* Do not attempt to rotate innfeed logs
	  
	  innfeed with funnel feeds will hold its log files open forever,
	  so those log files cannot be safely rotated with scanlogs.
	  There's no way to signal innfeed to close the log file and open a
	  new one. Remove the code in scanlogs that attempts to deal with
	  them.
	  
	  Patch from Florian Schlichting <fschlich@CIS.FU-Berlin.DE>.

2012-12-07  eagle

	* Remove reference to reap from prunehistory man page
	  
	  The FTP site from which this program was available seems to have
	  disappeared, and it was already marked as obsolete.

2012-09-04  iulius

	* Mention CVE-2012-3523 in the NEWS file (though posterior to the
	  2.5.3 release)

2012-07-07  eagle

	* Update URL for NewsPortal to one that works

2012-06-30  iulius

	* bump revision numbers to 2.5.4 (the following STABLE release)

