From xemacs-m  Fri Jul  4 17:42:49 1997
Received: from pc-zcalusic.srce.hr (hniksic@pc-zcalusic.srce.hr [161.53.2.132])
	by xemacs.org (8.8.5/8.8.5) with ESMTP id RAA16654
	for <xemacs-beta@xemacs.org>; Fri, 4 Jul 1997 17:42:48 -0500 (CDT)
Received: (from hniksic@localhost)
	by pc-zcalusic.srce.hr (8.8.5/8.8.5) id AAA15484;
	Sat, 5 Jul 1997 00:42:28 +0200
Message-ID: <19970705004223.36979@pc-zcalusic.srce.hr>
Date: Sat, 5 Jul 1997 00:42:23 +0200
From: Hrvoje Niksic <hniksic@pc-zcalusic.srce.hr>
To: xemacs-beta@xemacs.org
Subject: Re: Describe Bindings looses in quail-mode
References: <rxsyb7nt2fn.fsf@midnight.ecf.teradyne.com> <m2radesdzo.fsf@altair.xemacs.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Mailer: Mutt 0.69
In-Reply-To: <m2radesdzo.fsf@altair.xemacs.org>; from Steven L Baur on Fri, Jul 04, 1997 at 02:29:15PM -0700

> How does this look Hrvoje?
[...]
> +	  ;; (set-default 'minor-mode-map-alist (cons 'quail-mode map)))))
> +	  (set-default 'minor-mode-map-alist
> +		       (cons (cons 'quail-mode quail-mode-map) map)))))
[...]
> +    ;; End bogus code removal.
> +    (delete-if (lambda (item) (eq (car item) 'quail-mode))
> +	       minor-mode-map-alist)
> +    (setq minor-mode-map-alist
> +	  (cons (cons 'quail-mode quail-mode-map) minor-mode-map-alist))
> +

I think we should consistently use `add-minor-mode' for adding minor mode,
because it does other good stuff, like adding the correct modeline extents.

BTW, when you use `delete', you should probably setq to the original (in
case the first entry is being deleted).  Also, you can use the general
`delete*' in place of `delete-if', the result looking like this (tested):

(setq minor-mode-map-alist
      (delete* 'quail-mode minor-mode-map-alist
               :test #'eq
               :key #'car))

(add-minor-mode ...)


P.S.
If you grow *really* accustomed to CL-style generalized variables, you
can even rewrite the former as:

(callf2 delete* 'quail-mode minor-mode-map-alist
                :test #'eq :key #'car)

but it verges on the borders of good taste.

