From xemacs-m  Wed Aug 13 14:56:59 1997
Received: from logatome.micronet.fr (root@logatome.micronet.fr [194.51.75.1])
	by xemacs.org (8.8.5/8.8.5) with ESMTP id OAA00343;
	Wed, 13 Aug 1997 14:56:58 -0500 (CDT)
Received: from pppA120.francenet.fr (pppA120.francenet.fr [193.149.100.26])
	by logatome.micronet.fr (8.8.5/8.8.5) with SMTP id VAA26560;
	Wed, 13 Aug 1997 21:56:57 +0200 (MET DST)
From: hk444@cleveland.freenet.edu (Yves Blusseau)
To: bugs@xemacs.org
Cc: xemacs-beta@xemacs.org
Subject: Error when setting file modes with the efs package
Date: Wed, 13 Aug 1997 19:56:54 GMT
Reply-To: hk444@cleveland.freenet.edu
Message-ID: <33f3116e.3337649@mail.micronet.fr>
X-Mailer: Forte Agent 1.5/32.452
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by xemacs.org id OAA00344

X-send-pr-version: 3.101


>Submitter-Id:	net
>Originator:	system PRIVILEGED account
>Organization:
XEmacs Users
>Confidential:   no
>Synopsis:       Error when setting file modes with the efs package
>Severity:       serious
>Priority:       medium
>Category:       lisp
>Class:          sw-bug
>Release:	gnats-3.101
>Environment:
	<machine, os, target, libraries (multiple lines)>
System: OSF1 mimi60 V3.2 62 alpha
Machine: alpha
>Description:
	When you try to set the file modes of a remote file with the set-file-modes function (the
true function called is efs-set-file-modes) and the remote station have a FTP Daemon that don't
support the QUOTE function (like Sun Solaris Platform) you obtained the following message in the
*warning* buffer:
	(1) (error/warning) Error in process filter: (void-variable mode)

>How-To-Repeat:
Example:
	Create a file /tmp/toto on a Sun Solaris Workstation (mimi07 here):
	# touch /tmp/toto
	From another station try to change the modes of the file (evaluate this lines with xemacs):
	(set-file-modes "/root@mimi07:/tmp/toto" 73)

>Fix:
	The problem is at the line 8175 of the xemacs-20.3-b17/lisp/efs/efs.el package. The line is:
		(concat "chmod " mode " " (file-name-nondirectory file))
	and SHOULD BE
		(concat "chmod " omode " " (file-name-nondirectory file))

	The bug is that the variable mode is not defined in the continuation function of the
efs-send-cmd that is start from the efs-set-file-modes function.

The PATCH file is:

*** xemacs-20.3-b17/lisp/efs/efs.el	Sun Apr 27 21:30:06 1997
--- xemacs-20.3-b17/lisp/efs/efs.el	Wed Aug 13 14:41:20 1997
***************
*** 8172,8178 ****
  	      (if result
  		  (let ((exit-code
  			 (efs-shell-call-process
! 			  (concat "chmod " mode " " (file-name-nondirectory file))
  			  (file-name-directory file))))
  		    (if (not (equal 0 exit-code))
			(progn                         
--- 8172,8178 ----
  	      (if result
  		  (let ((exit-code
  			 (efs-shell-call-process
! 			  (concat "chmod " omode " " (file-name-nondirectory file))
  			  (file-name-directory file))))
  		    (if (not (equal 0 exit-code))                       
			(progn
*** xemacs-20.3-b17/lisp/ChangeLog	Tue Aug 12 13:45:34 1997
--- xemacs-20.3-b17/lisp/ChangeLog	Wed Aug 13 19:09:55 1997
***************
*** 1,3 ****
--- 1,9 ----
+ 1997-08-13  Yves BLUSSEAU  <hk444@cleveland.freenet.edu>
+ 
+ 	* efs/efs.el (efs-set-file-modes): Fix a bug that cause an error
+ 	when using the efs-set-file-modes function on a remote station with
+ 	a FTP daemon that don't support the QUOTE function.
+ 
  1997-08-09  Karl M. Hegbloom  <karlheg@inetarena.com>
  
  	* packages/info.el: (info::toolbar) swap next and prev buttons to
----------------------------------------------- END OF PATCH --------------------------------------

                         \\\|/// 
                       \\  ~ ~  //
                        (  @ @  )
*---------------------oOOo-(_)-oOOo------------------------*
| Yves Blusseau                                            |
|                                                          |
| E-Mail    :   hk444@cleveland.freenet.edu                |
|    or         blusseau@pharmacie.unicaen.fr              |
|    or         blusseau@ifh.sncf.fr                       |
|                                                          |
| Home Page :  http://www.pharmacie.unicaen.fr/blusseau    |
|                                                          |
|    IRC    :   nick IF (channels #francais #cyberchum)    |
*----------------------------Oooo.-------------------------*
                  .oooO      (   )
                  (   )       ) /
                   \ (       (_/
                    \_)

