From xemacs-m  Fri Aug 15 08:56:39 1997
Received: from ns2.eds.com (ns2.eds.com [199.228.142.78])
	by xemacs.org (8.8.5/8.8.5) with ESMTP id IAA22277
	for <xemacs-beta@xemacs.org>; Fri, 15 Aug 1997 08:56:38 -0500 (CDT)
Received: from nnsp.eds.com (nnsp2.eds.com [199.228.143.130])
	by ns2.eds.com (8.8.6/8.8.5) with ESMTP id JAA19032
	for <xemacs-beta@xemacs.org>; Fri, 15 Aug 1997 09:56:40 -0400 (EDT)
Received: from kocrsv04.delcoelect.com (kocrsv04.delcoelect.com [144.250.100.205])
	by nnsp.eds.com (8.8.5/8.8.5) with ESMTP id JAA05763
	for <xemacs-beta@xemacs.org>; Fri, 15 Aug 1997 09:56:40 -0400 (EDT)
Received: from kocrsw12.delcoelect.com (kocrsw12.delcoelect.com [144.250.106.18]) by kocrsv04.delcoelect.com (8.7.5/8.7.3) with SMTP id IAA09538 for <xemacs-beta@xemacs.org>; Fri, 15 Aug 1997 08:56:39 -0500 (EST)
Received: from kocrsw12 by kocrsw12.delcoelect.com (SMI-8.6/SMI-SVR4)
	id IAA05484; Fri, 15 Aug 1997 08:56:37 -0500
X-Mailer: exmh version 2.0gamma 1/27/97
To: xemacs-beta@xemacs.org
Subject: Re: [bug] `edit-toolbar.el' 
X-Attribution: mts
X-Face: 4tk3bJx]I+QTZ|=]*1+Z){9+;5u_hK*NBeZK6[+B+iB%bVuOJ%^uK~fIG}O-}%WLX*D
 ^aW>Gv8E3Xtz0\N&fQl^:pj<K{xM`:d>pPt:9lF-YXB%O)?@rd?*/jE!s94`?]:jJ#C5RDP:;M
 r.3lwo`0{vIT+<{%IRwe]vLd]7>\X|*z{TUX_t;?TPcOLBMIv8_V92!Vk(*DJVU~0M[`5D^PAW
 LniO1?YYWArMU*j9o+>?1MWi.lO?F-?aVt:qQ8OaG?R}B:I!7S_+KuzxZ.f9M@$z#n\bG2$Q2{od
Date: Fri, 15 Aug 1997 08:56:36 -0500
Message-ID: <5482.871653396@kocrsw12>
From: Mike Scheidler <c23mts@eng.delcoelect.com>

"Karl" == Karl M Hegbloom <karlheg@inetarena.com> writes:
 Karl> 
 Karl>  There's still a problem with `edit-toolbar'.  It asks for filenames
 Karl> of glyph images, and make the toolbar fine.  But when it saves it, it
 Karl> writes unreadable specifiers into the .toolbar file.

Yes, I caught your message about this problem a few days ago, but I don't
have a ready solution.  It appears that there's some discrepancy between
what's acceptable as internal representation and what's valid to load from
a file.  To be specific, it looks like the lisp reader is barfing when it
finds a '<' in the input stream.

The way things are implemented, it's kind of a chicken-and-egg problem--the
lisp reader is expecting to read in a symbol which defines the glyph list
(e.g. `toolbar-calc-icon'), but at that point the glyph list hasn't been
created yet.

 Karl>  I think that code needs to be added to write a form into .toolbar
 Karl> that makes a glyph-set be created before the toolbar is defined...

This would work (and is no doubt the easiest solution) but it seems like a
hack.  In fact, I can't see much added value in defining all of these
`toolbar-*-icon' variables.  It would seem lot cleaner to define a toolbar
entry vector as something like

    [(toolbar-add-item-data file-icon-list) toolbar-open t "Open a file"]

 Karl> I'm not sure what the Complete and Right Solution is.

Same here.  Making changes to the lisp reader isn't something I'd even
consider tackling myself, but I think that the Right Thing would be to fix
it to recognize the form that's currently being written to the .toolbar
file.  This would also allow the toolbar definition code to be cleaned up,
getting rid of the dependence on predefined `toolbar-*-icon' variables.

Any comments from someone more familiar with this stuff?

-- 
Mike Scheidler                     c23mts@eng.delcoelect.com
Corporate Software Technology
Delco Electronics Corporation      PHONE:  (765) 451-0319
Kokomo, IN 46904-9005              GMNET:  8-322-0319


