From xemacs-m  Fri Sep 26 09:33:42 1997
Received: from jagor.srce.hr (hniksic@jagor.srce.hr [161.53.2.130])
	by xemacs.org (8.8.5/8.8.5) with ESMTP id JAA21975
	for <xemacs-beta@xemacs.org>; Fri, 26 Sep 1997 09:33:34 -0500 (CDT)
Received: (from hniksic@localhost)
	by jagor.srce.hr (8.8.7/8.8.6) id QAA06986;
	Fri, 26 Sep 1997 16:33:22 +0200 (MET DST)
To: XEmacs Developers <xemacs-beta@xemacs.org>
Subject: Re: [patch] help (includes newest find-func)
References: <lbafh0nsx7.fsf@boron.kurims.kyoto-u.ac.jp>
X-Attribution: Hrvoje
X-Face: Mie8:rOV<\c/~z{s.X4A{!?vY7{drJ([U]0O=W/<W*SMo/Mv:58:*_y~ki>xDi&N7XG
        KV^$k0m3Oe/)'e%3=$PCR&3ITUXH,cK>]bci&<qQ>Ff%x_>1`T(+M2Gg/fgndU%k*ft
        [(7._6e0n-V%|%'[c|q:;}td$#INd+;?!-V=c8Pqf}3J
From: Hrvoje Niksic <hniksic@srce.hr>
Date: 26 Sep 1997 16:33:22 +0200
In-Reply-To: Jens-Ulrik Holger Petersen's message of "26 Sep 1997 21:47:16 +0900"
Message-ID: <kig4t78jgb1.fsf@jagor.srce.hr>
Lines: 62
X-Mailer: Quassia Gnus v0.10/XEmacs 20.3(beta23) - "Sarajevo"

Jens-Ulrik Holger Petersen <petersen@kurims.kyoto-u.ac.jp> writes:

> -    (if file-name
> -	(princ (format "  -- loads from \"%s\"\n" file-name) stream))
> -    (if home
> -	(princ (format "  -- loaded from \"%s\"\n" home)) stream)
> +    (if (or home file-name)
> +	(princ (format "  -- defined in \"%s\"\n" (or home file-name)) stream))

I don't like this change.  There was a distinction between "loads
from" and "loaded from", which is now gone.  For instance:

`gnus' is an interactive compiled Lisp function
  -- loads from "gnus"
  -- loaded from "gnus.elc"
(gnus &optional ARG DONT-CONNECT SLAVE)

With your patch, I would only see:

  -- defined in "gnus.elc"

In this case, this may be fine, but there are cases where I want to
see the autoload, too.

> +	   (filename (if (file-exists-p library)
> +			 library
> +		       (if (string-match "\\(\\.el\\)\\'" library)
> +			   (setq library (substring library 0
> +						    (match-beginning 1))))
> +		       (or (locate-library (concat library ".el")
> +					   t path)
> +			   (locate-library library t path)
> +			   (if compression
> +			       (or (locate-library (concat library ".el.gz")
> +						   t path)
> +				   (locate-library (concat library ".gz")
> +						   t path)))))))

Hmm.  This is not good.  `locate-library' knows about compression
itself (look at packages.el), so it is unnecessary to duplicate that
work here.  I thought one of my patches addressed it?  Hmm.  It was
probably one of those that were unintentionally delayed for b24.  In
my copy of help.el the code looks like this:

...
    (let* ((path (or path find-function-source-path))
	   (filename (or (locate-library (concat library ".el") t path)
			 (locate-library library t path))))
      (if (not filename)
	  (error "The library \"%s\" is not in the path." library))
...

And that's it.  Steve, what does that part look in your copy?


Otherwise, the patches are fine!  I also like the fact that you added
the appropriate histories to minibuffer prompts.

-- 
Hrvoje Niksic <hniksic@srce.hr> | Student at FER Zagreb, Croatia
--------------------------------+--------------------------------
Speak softly and carry a +6 two-handed sword.

