From xemacs-m  Wed Jan 15 17:19:38 1997
Received: from venus.Sun.COM (venus.Sun.COM [192.9.25.5])
          by xemacs.org (8.8.4/8.8.4) with SMTP
	  id RAA24919 for <xemacs-beta@xemacs.org>; Wed, 15 Jan 1997 17:19:37 -0600 (CST)
Received: from Eng.Sun.COM ([129.146.1.25]) by venus.Sun.COM (SMI-8.6/mail.byaddr) with SMTP id PAA05514; Wed, 15 Jan 1997 15:19:06 -0800
Received: from kindra.eng.sun.com by Eng.Sun.COM (SMI-8.6/SMI-5.3)
	id PAA10119; Wed, 15 Jan 1997 15:19:00 -0800
Received: from xemacs.eng.sun.com by kindra.eng.sun.com (SMI-8.6/SMI-SVR4)
	id PAA20766; Wed, 15 Jan 1997 15:18:58 -0800
Received: by xemacs.eng.sun.com (SMI-8.6/SMI-SVR4)
	id PAA29672; Wed, 15 Jan 1997 15:18:58 -0800
Date: Wed, 15 Jan 1997 15:18:58 -0800
Message-Id: <199701152318.PAA29672@xemacs.eng.sun.com>
From: Martin Buchholz <mrb@Eng.Sun.COM>
To: David Moore <dmoore@UCSD.EDU>
Cc: XEmacs Beta Mailing List <xemacs-beta@xemacs.org>
Subject: Re: 20.0-b90: some bugs
In-Reply-To: <rvhgkin2zh.fsf@sdnp5.ucsd.edu>
References: <18358.853186100@rtp.ericsson.se>
	<199701150713.XAA28262@xemacs.eng.sun.com>
	<rvhgkin2zh.fsf@sdnp5.ucsd.edu>
Reply-To: Martin Buchholz <mrb@Eng.Sun.COM>
Mime-Version: 1.0 (generated by tm-edit 7.100)
Content-Type: text/plain; charset=US-ASCII

>>>>> "David" == David Moore <dmoore@UCSD.EDU> writes:

David> Martin Buchholz <mrb@Eng.Sun.COM> writes:
>> I fixed a bug (accept-process-output) in 19.14 that had the exact same
>> symptoms.  I checked the versions of accept-process-output between my
>> personal workspace and Steven's (there is some slight divergence) and
>> noticed that accept-process-output is different.  Perhaps the code in
>> the following diff is responsible.  Where did this code come from???
>> Would undoing this change fix the problem?

David> 	I provided the event_stream_wakeup_pending_p code, it's the fix
David> for the sit-for and other bugs where you recursively call sit-for,
David> sleep-for or accept-process-output.  However I messed up in
David> accept-process-output and checked an unitialized variable.  Patch below.

Thanks for the correction, David.  Your patch feels correct.  

Beta testers: Please confirm that this fixes the
(accept-process-output) problems with ispell.

Steven: Please do not apply the diff I posted - it was just for
reference.  Apply David's patch below instead.

David> --- event-stream.c.orig	Wed Jan 15 11:36:25 1997
David> +++ event-stream.c	Wed Jan 15 11:36:33 1997
David> @@ -2432,7 +2432,7 @@
David>  	 || (!EQ (result, Qt) && event_stream_event_pending_p (0)))
David>      {
David>        /* If our timeout has arrived, we move along. */
David> -      if (!event_stream_wakeup_pending_p (timeout_id, 0))
David> +      if (timeout_enabled && !event_stream_wakeup_pending_p (timeout_id, 0))
David>  	{
David>  	  timeout_enabled = 0;
David>  	  process = Qnil;	/* We're  done. */

