From xemacs-m  Fri Feb  7 08:22:44 1997
Received: from portofix.ida.liu.se (portofix.ida.liu.se [130.236.177.25])
	by xemacs.org (8.8.5/8.8.5) with ESMTP id IAA07730
	for <xemacs-beta@xemacs.org>; Fri, 7 Feb 1997 08:22:42 -0600 (CST)
Received: from sen2.ida.liu.se (sen2.ida.liu.se [130.236.176.112]) by portofix.ida.liu.se (8.8.3/8.8.3) with SMTP id PAA18422 for <xemacs-beta@xemacs.org>; Fri, 7 Feb 1997 15:22:40 +0100 (MET)
Received: by sen2.ida.liu.se (SMI-8.6/ida.slave-V1.0b6d6S2)
	id PAA29298; Fri, 7 Feb 1997 15:22:40 +0100
Date: Fri, 7 Feb 1997 15:22:40 +0100
Message-Id: <199702071422.PAA29298@sen2.ida.liu.se>
From: David Byers <davby@ida.liu.se>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
To: xemacs-beta@xemacs.org
Subject: Re: 20.0 --with-mule segfaults when viewing Japanese
In-Reply-To: <199702070342.TAA14213@xemacs.eng.sun.com>
References: <yviasp3digdf.fsf@atreides.mindspring.com>
	<199702041227.NAA17114@sen2.ida.liu.se>
	<kig6808gqbw.fsf@jagor.srce.hr>
	<199702070342.TAA14213@xemacs.eng.sun.com>
X-Face: (@~#v$c[GP"T}a;|MU<%Dpm5*6yv"NR|7k;uk8MAISFxdZ(Og$C{u(j"9X7v$qonp}SKfhT
 g|5[Pu~/3F7XQEk70gK'4z%1R%%gg7]}=>/jD`qcBeHDgo&HS,^S!&.zoTSxh<>-O6EB?SSy96&m37

> Hrv> Maybe you should add an #ifdef DEBUG or something make the patch issue
> Hrv> a warning that the maintainers can use as a pointer to where the
> Hrv> problem is.
> 
> I agree.
> 
> In general, it's BAD to add a patch that fixes a crash by fixing the
> symptom, especially when it's a crash the maintainers don't get
> themselves. 

The real bug in this case is that display tables _by_design_ only can
handle characters 0-255. Given that this design is intentional and
that display tables are supposed to work even in an environment with
multi-byte characters, and it seems to be that way, the patch I sent
fixes a very real bug.

However, the real fix would be to extend display tables to handle more
than 256 characters, and there's already a long comment regarding
this, including some good suggestions about what to do, in the code. I
must assume that this means that the problem is not unknown.

In general, I agree with your comments. Just not in this case.

--
David Byers.

