From xemacs-m  Fri Feb  7 12:39:26 1997
Received: from altair.xemacs.org (steve@xemacs.miranova.com [206.190.83.19])
	by xemacs.org (8.8.5/8.8.5) with ESMTP id MAA08689
	for <xemacs-beta@xemacs.org>; Fri, 7 Feb 1997 12:39:25 -0600 (CST)
Received: (from steve@localhost)
	by altair.xemacs.org (8.8.5/8.8.5) id KAA24840;
	Fri, 7 Feb 1997 10:50:30 -0800
To: xemacs-beta@xemacs.org
Subject: Re: 20.0 --with-mule segfaults when viewing Japanese
References: <yviasp3digdf.fsf@atreides.mindspring.com> 	<199702041227.NAA17114@sen2.ida.liu.se> 	<kig6808gqbw.fsf@jagor.srce.hr> 	<199702070342.TAA14213@xemacs.eng.sun.com> 	<199702071422.PAA29298@sen2.ida.liu.se> 	<kighgjo4nav.fsf@jagor.srce.hr> <199702071636.RAA29564@sen2.ida.liu.se>
X-Url: http://www.miranova.com/%7Esteve/
Mail-Copies-To: never
X-Face: #!T9!#9s-3o8)*uHlX{Ug[xW7E7Wr!*L46-OxqMu\xz23v|R9q}lH?cRS{rCNe^'[`^sr5"
 f8*@r4ipO6Jl!:Ccq<xoV[Qz2u8<8-+Vwf2gzJ44lf_/y9OaQ`@#Q65{U4/TC)i2`~/M&QI$X>p:9I
 OSS'2{-)-4wBnVeg0S\O4Al@)uC[pD|+
X-Attribution: sb
From: Steven L Baur <steve@miranova.com>
In-Reply-To: David Byers's message of Fri, 7 Feb 1997 17:36:50 +0100
Mime-Version: 1.0 (generated by tm-edit 7.101)
Content-Type: text/plain; charset=US-ASCII
Date: 07 Feb 1997 10:50:30 -0800
Message-ID: <m2vi841mdl.fsf@altair.xemacs.org>
Lines: 16
X-Mailer: Gnus v5.4.11/XEmacs 20.0

David Byers writes:

> The first needs bounds checking. The second *could* to without since
> it is called only if the first lookup finds an entry in the display
> table (which implies that the character is within the bounds of the
> display table) but the miniscule performance gain to me isn't worth
> the loss of clarity resulting from the use of two nearly identical
> but subtly different macros. Others may disagree.

I don't have a problem with a little extra error/bounds checking for
safety.  I do have a problem with cloning special case code as it
tends to become unmaintainable.  I don't see a problem with David's
patch even if the corrected macro were more widely called.
-- 
steve@miranova.com baur
Unsolicited commercial e-mail will be billed at $250/message.

