From xemacs-m  Thu Dec 12 17:49:06 1996
Received: from venus.Sun.COM (venus.Sun.COM [192.9.25.5]) by xemacs.cs.uiuc.edu (8.8.3/8.8.3) with SMTP id RAA05042 for <xemacs-beta@xemacs.org>; Thu, 12 Dec 1996 17:49:05 -0600 (CST)
Received: from Eng.Sun.COM ([129.146.1.25]) by venus.Sun.COM (SMI-8.6/mail.byaddr) with SMTP id PAA16746; Thu, 12 Dec 1996 15:48:37 -0800
Received: from kindra.eng.sun.com by Eng.Sun.COM (SMI-8.6/SMI-5.3)
	id PAA16456; Thu, 12 Dec 1996 15:48:35 -0800
Received: from xemacs.eng.sun.com by kindra.eng.sun.com (SMI-8.6/SMI-SVR4)
	id PAA15664; Thu, 12 Dec 1996 15:48:35 -0800
Received: by xemacs.eng.sun.com (SMI-8.6/SMI-SVR4)
	id PAA28732; Thu, 12 Dec 1996 15:48:32 -0800
Date: Thu, 12 Dec 1996 15:48:32 -0800
Message-Id: <199612122348.PAA28732@xemacs.eng.sun.com>
From: Martin Buchholz <mrb@Eng.Sun.COM>
To: Raymond Toy <toy@rtp.ericsson.se>
Cc: XEmacs Mailing List <xemacs-beta@xemacs.org>, ilisp@naggum.no
Subject: XEmacs 20.0-b30:  bug in ilisp
In-Reply-To: <15113.850422469@rtp.ericsson.se>
References: <15113.850422469@rtp.ericsson.se>
Reply-To: Martin Buchholz <mrb@Eng.Sun.COM>
Mime-Version: 1.0 (generated by tm-edit 7.94)
Content-Type: text/plain; charset=US-ASCII

>>>>> "Ray" == Raymond Toy <toy@rtp.ericsson.se> writes:

Ray> Found a small bug in ilisp-out.el.  It checks for emacs-minor-version
Ray> less than 12 without checking emacs-major-version.  Ilisp isn't able
Ray> to open a new window because it uses window-edges.  A simple fix is
Ray> enclosed.

I will apply this patch to the ilisp in XEmacs 20.0.

I upgraded ilisp within XEmacs, but I don't actually use it - so other
things are likely to be broken too.  Ray, could you take nominal
ownership of integrating with XEmacs?  Also, patches of this nature
should go to the ilisp maintainers.  From the ilisp README:

Written by Chris McConnell <ccm+@cs.cmu.edu> and now maintained by
Marco Antoniotti <marcoxa@icsi.berkeley.edu> and
Rick Campbell <campbell@c2.net>.

Please send bug reports, questions, suggestions, etc. to:
  ILISP Discussion <ilisp@naggum.no>

Please address all list administration messages, such as requests to
subscribe or unsubscribe from ilisp@naggum.no, to:
  ILISP Administrivia <ilisp-request@naggum.no>

See http://www.c2.net/~campbell/ilisp/ or
http://www.cs.cmu.edu/~campbell/ilisp/ for more information.

Ray> For true portability, I think some of the code needs to be rethought.
Ray> For example +ilisp-emacs-minor-version-number+ is always 14 because it
Ray> xemacs.  But then in ilisp-out.el, we use emacs-minor-version to find
Ray> out the version instead of using +ilisp-emacs-minor-version+.  There
Ray> are other bugs like that.  I'd fix them, but I'm not exactly sure of
Ray> the intent of the original author

Ray> Patch for ilisp-out.el

Ray> --- ilisp-out.el~	Fri Nov  8 00:14:26 1996
Ray> +++ ilisp-out.el	Thu Dec 12 15:22:24 1996
Ray> @@ -262,7 +262,8 @@
Ray>    "Find the window directly below us, if any.  This is probably the 
Ray>   window from which enlarge-window would steal lines."
Ray>    (if (or (not (string-match "XEmacs" emacs-version))
Ray> -	  (< emacs-minor-version 12))
Ray> +	  (and (= emacs-major-version 19)
Ray> +	       (< emacs-minor-version 12)))
Ray>        (let* ((bottom (nth 3 (window-edges window)))
Ray>  	     (window* nil)
Ray>  	     (win window))
Ray> @@ -279,7 +280,8 @@
Ray>  (defun ilisp-find-top-left-most-window ()
Ray>    "Return the leftmost topmost window on the current screen."
Ray>    (if (or (not (string-match "XEmacs" emacs-version))
Ray> -	  (< emacs-minor-version 12))
Ray> +	  (and (= emacs-major-version 19)
Ray> +	       (< emacs-minor-version 12)))
Ray>        (let* ((window* (selected-window))
Ray>  	     (edges* (window-edges window*))
Ray>  	     (win nil)


