From xemacs-m  Wed May 28 18:56:14 1997
Received: from cerise.sensei.co.uk (glynn@muvies.demon.co.uk [158.152.66.14])
	by xemacs.org (8.8.5/8.8.5) with ESMTP id SAA21060
	for <xemacs-beta@xemacs.org>; Wed, 28 May 1997 18:56:12 -0500 (CDT)
Received: (from glynn@localhost) by cerise.sensei.co.uk (8.8.2/8.8.2) id XAA00879; Wed, 28 May 1997 23:24:59 +0100
Date: Wed, 28 May 1997 23:24:59 +0100
Message-Id: <199705282224.XAA00879@cerise.sensei.co.uk>
From: Glynn Clements <glynn@sensei.co.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
To: xemacs-beta@xemacs.org
Subject: Re: man.el
In-Reply-To: <199705110041.TAA24411@xemacs.org>
References: <199705110041.TAA24411@xemacs.org>
X-Mailer: VM 6.31 under 20.2 XEmacs Lucid


David Bakhash wrote:

> If you're gonna fix up man.el, there are some more things to be aware
> of:

 [snipped]

> it still thinks it can't find it b/c man.el leaves this worthless
> buffer lying around even when it can't make the manpage.  This is both
> a waste of a buffer and, as far as I'm concerned, a bug.

Yeah, that started getting on my nerves, so I fixed it by adding a
kill-buffer.

The following patch is against 20.2 with my previous patch applied. As 
the previous patch discarded stderr output, there's not much point
trying to get the error message out of the buffer.

-- 
Glynn Clements <glynn@sensei.co.uk>


--- /usr/src/xemacs-20.2/lisp/packages/man.el.orig	Wed May 28 23:15:35 1997
+++ /usr/src/xemacs-20.2/lisp/packages/man.el	Wed May 28 23:18:06 1997
@@ -247,10 +247,10 @@
 
 		   (if (< (buffer-size) 200)
 		       (progn
-			 (goto-char (point-min))
-			 (error (buffer-substring (point)
-						  (progn (end-of-line)
-							 (point))))))
+			 (kill-buffer (current-buffer))
+			 (error "%s not found" args-string)
+			 )
+		     )
 
 		   (message "%s (cleaning...)" args-string)
 		   (Manual-nuke-nroff-bs apropos-mode)

