From xemacs-m  Thu Jun 12 03:27:09 1997
Received: from jagor.srce.hr (hniksic@jagor.srce.hr [161.53.2.130])
	by xemacs.org (8.8.5/8.8.5) with ESMTP id DAA20062
	for <xemacs-beta@xemacs.org>; Thu, 12 Jun 1997 03:27:07 -0500 (CDT)
Received: (from hniksic@localhost)
          by jagor.srce.hr (8.8.5/8.8.4)
	  id KAA07689; Thu, 12 Jun 1997 10:27:06 +0200 (MET DST)
To: XEmacs Developers <xemacs-beta@xemacs.org>
Subject: [PATCH] `M-x makefile-browse' fails
X-Attribution: Hrv
X-Face: Mie8:rOV<\c/~z{s.X4A{!?vY7{drJ([U]0O=W/<W*SMo/Mv:58:*_y~ki>xDi&N7XG
        KV^$k0m3Oe/)'e%3=$PCR&3ITUXH,cK>]bci&<qQ>Ff%x_>1`T(+M2Gg/fgndU%k*ft
        [(7._6e0n-V%|%'[c|q:;}td$#INd+;?!-V=c8Pqf}3J
From: Hrvoje Niksic <hniksic@srce.hr>
Date: 12 Jun 1997 10:27:06 +0200
Message-ID: <kigvi3k1b1h.fsf@jagor.srce.hr>
Lines: 24
X-Mailer: Gnus v5.4.52/XEmacs 20.3(beta5)

I think it's obscene to add the `(interactive)' specification just for 
the kicks of it.  Not only does it add to the completion pool, but it
is misleading.

For example, I new there was a Makefile browser within make-mode.  So
I tried `M-x makefile-browse'.  Bummer -- wrong number of arguments.
The correct form is something like `makefile-switch-to-browser'.

--- lisp/modes/make-mode.el.orig	Thu Jun 12 10:23:40 1997
+++ lisp/modes/make-mode.el	Thu Jun 12 10:23:48 1997
@@ -1140,7 +1140,6 @@
   (setq buffer-read-only t))
 
 (defun makefile-browse (targets macros)
-  (interactive)
   (if (zerop (+ (length targets) (length macros)))
       (progn
 	(beep)


-- 
Hrvoje Niksic <hniksic@srce.hr> | Student at FER Zagreb, Croatia
--------------------------------+--------------------------------
Oh lord won't you buy me a color TV...

