From xemacs-m  Fri Jun 13 21:20:43 1997
Received: from altair.xemacs.org (steve@xemacs.miranova.com [206.190.83.19])
	by xemacs.org (8.8.5/8.8.5) with ESMTP id VAA20987
	for <xemacs-beta@xemacs.org>; Fri, 13 Jun 1997 21:20:42 -0500 (CDT)
Received: (from steve@localhost)
	by altair.xemacs.org (8.8.5/8.8.5) id TAA09581;
	Fri, 13 Jun 1997 19:20:47 -0700
Mail-Copies-To: never
To: xemacs-beta@xemacs.org
Subject: Re: dired ebola
References: <bciiuzitcbs.fsf@corp.Sun.COM>
X-Url: http://www.miranova.com/%7Esteve/
X-Face: #!T9!#9s-3o8)*uHlX{Ug[xW7E7Wr!*L46-OxqMu\xz23v|R9q}lH?cRS{rCNe^'[`^sr5"
 f8*@r4ipO6Jl!:Ccq<xoV[Qz2u8<8-+Vwf2gzJ44lf_/y9OaQ`@#Q65{U4/TC)i2`~/M&QI$X>p:9I
 OSS'2{-)-4wBnVeg0S\O4Al@)uC[pD|+
X-Attribution: sb
From: Ebola Vaccinations R Us <steve@xemacs.org>
In-Reply-To: Gary.Foster@Corp.Sun.COM's message of "13 Jun 1997 14:36:23 -0700"
Mime-Version: 1.0 (generated by tm-edit 7.108)
Content-Type: text/plain; charset=US-ASCII
Date: 13 Jun 1997 19:20:45 -0700
Message-ID: <m2wwny2ade.fsf@altair.xemacs.org>
Lines: 37
X-Mailer: Gnus v5.4.56/XEmacs 20.3(beta7) - "Oslo"

Gary D Foster <Gary.Foster@Corp.Sun.COM> writes:

> dired-do-copy gives me ebola warnings:
>    [byte-code, dired-get-marked-files, dired-do-create-files, dired-do-copy, call-interactively]
> Comparison between integer and character is constant nil (0 and ?\ )
>    [byte-code, dired-add-entry, apply, dired-fun-in-all-buffers, dired-add-file, byte-code, <compiled-function from "dired.elc">, mapcar, efs-real-dired-create-files, dired-create-files, dired-do-create-files, dired-do-copy, call-interactively]
> Comparison between integer and character is constant nil (0 and ?\ )
>    [byte-code, efs-real-dired-create-files, dired-create-files, dired-do-create-files, dired-do-copy, call-interactively]

Yup.  This code was probably O.K. sans possible embedded NUL problems.
Here is a patch to get rid of the warnings.  Michael, could you please
apply this patch to your sources?

1997-06-13  Steven L Baur  <steve@altair.xemacs.org>

	* efs/dired.el (dired-save-excursion): Ebola cleanup.

Index: lisp/efs/dired.el
===================================================================
RCS file: /usr/local/xemacs/xemacs-20.0/lisp/efs/dired.el,v
retrieving revision 1.9
diff -u -r1.9 dired.el
--- dired.el	1997/06/06 00:56:50	1.9
+++ dired.el	1997/06/14 02:13:45
@@ -739,7 +739,7 @@
 	   ;; the proper column.
 	   (goto-char (, temp-bolm))
 	   (and (not (, temp-fnlp))
-		(not (eq (following-char) 0)) (memq (following-char) '(?\n ?\r))
+		(memq (char-after (point)) '(?\n ?\r))
 		;; The line containing the point got deleted. Note that this
 		;; logic only works if we don't delete null lines, but we never
 		;; do.

-- 
steve@calag.com baur
Unsolicited commercial e-mail will be billed at $250/message.

